-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: add confirm action component via context #3230
Closed
Closed
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
15c0c61
add confirm action component
jecr e2287a3
Add confirmAction props
jecr f31809d
add optional actionLabel
jecr 9b77058
allow the modal desription to be a string or a component
jecr 91921b9
make context prop optional
jecr ec05319
clear input
jecr 2e63c66
update styled import, simplify effect hook
jecr 7b52057
clear on open change
jecr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
import React from "react"; | ||
import { | ||
Button, | ||
ConfirmActionProps, | ||
Dialog, | ||
DialogActions, | ||
DialogContent, | ||
TextField, | ||
Typography, | ||
} from "@clutch-sh/core"; | ||
|
||
interface ConfirmActionDialogProps extends ConfirmActionProps { | ||
open: boolean; | ||
onCancel: () => void; | ||
} | ||
|
||
const ConfirmAction: React.FC<ConfirmActionDialogProps> = ({ | ||
open, | ||
title, | ||
description, | ||
confirmationText, | ||
actionLabel, | ||
onConfirm, | ||
onCancel, | ||
}) => { | ||
const [input, setInput] = React.useState(""); | ||
|
||
React.useEffect(() => setInput(""), [open]); | ||
|
||
const handleConfirm = () => { | ||
if (input === confirmationText) { | ||
onConfirm(); | ||
} | ||
}; | ||
|
||
return ( | ||
<Dialog title={title} open={open} onClose={onCancel}> | ||
<DialogContent> | ||
{typeof description === "string" ? ( | ||
<Typography variant="body1">{description}</Typography> | ||
) : ( | ||
description | ||
)} | ||
<TextField | ||
label="Confirmation" | ||
value={input} | ||
onChange={e => setInput(e.target.value)} | ||
fullWidth | ||
/> | ||
Comment on lines
+44
to
+49
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We may want to leave this as part of the description. We may prefer to have to some workflows with a confirmation but not necessarily requiring an input, so that should be left up to the implementer. |
||
</DialogContent> | ||
<DialogActions> | ||
<Button text="Cancel" onClick={onCancel} variant="neutral" /> | ||
<Button | ||
text={actionLabel || "Confirm"} | ||
onClick={handleConfirm} | ||
variant="danger" | ||
disabled={input !== confirmationText} | ||
/> | ||
</DialogActions> | ||
</Dialog> | ||
); | ||
}; | ||
|
||
export default ConfirmAction; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll probably want to leave this to the implementer as well. We will likely want a generic reason field versus something specific, better auditing that way.