Fpath #7
Merged
Fpath #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Rename most file path variables from [filename] to [path] and switch
from type [string] to [Fpath.t]
```diff
- filename:string
+ path:Fpath.t
```
2. Extract some libraries into their own packages to reuse in other
projects: loc, error-log, parsing-utils.
In the process of doing [2], the interface of the [fmt] command
changed slightly: now the extension is configured in the code and
doesn't need to be supplied in the dune files invocations.
For example:
```diff
(with-stdout-to
dune.inc.gen
(pipe-stdout
- (bash "%{bin:bopkit} fmt gen-dune .bop -- \%{bin:bopkit} fmt file")
+ (bash "%{bin:bopkit} fmt gen-dune -- \%{bin:bopkit} fmt file")
(run dune format-dune-file)))))
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal refactoring.
Using fpath
Rename most file path variables from
filenametopathand switch from typestringtoFpath.t.Extract some libraries into their own packages
Extract some libraries into their own packages to reuse in other projects:
loc,error-log,parsing-utils.The parts of
parsing-utilsthat relates to auto-format have been separated out and published as a new packageauto-format.In the process of doing that, the interface of the
fmtcommand changed slightly: now the extension is configured in the code and doesn't need to be supplied at each of the dune files invocations.For example: