Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fpath #7

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Fpath #7

merged 2 commits into from
Nov 16, 2023

Commits on Nov 12, 2023

  1. update pp dependency

    @mbarbin
    mbarbin committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    131eeb9 View commit details
    Browse the repository at this point in the history

  2. internal refactoring 

    1. Rename most file path variables from [filename] to [path] and switch
   from type [string] to [Fpath.t]

```diff
- filename:string
+ path:Fpath.t
```

2. Extract some libraries into their own packages to reuse in other
   projects: loc, error-log, parsing-utils.

In the process of doing [2], the interface of the [fmt] command
changed slightly: now the extension is configured in the code and
doesn't need to be supplied in the dune files invocations.

For example:

```diff
  (with-stdout-to
    dune.inc.gen
    (pipe-stdout
-    (bash "%{bin:bopkit} fmt gen-dune .bop -- \%{bin:bopkit} fmt file")
+    (bash "%{bin:bopkit} fmt gen-dune -- \%{bin:bopkit} fmt file")
     (run dune format-dune-file)))))
```
    @mbarbin
    mbarbin committed Nov 12, 2023
    Configuration menu
    Copy the full SHA
    66e45dd View commit details
    Browse the repository at this point in the history