Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSS grid layout guide refresh: auto-placement and alignment #38004

Merged
merged 2 commits into from
Feb 7, 2025
Merged

CSS grid layout guide refresh: auto-placement and alignment #38004

merged 2 commits into from
Feb 7, 2025
+97 −67

Conversation

estelle
Copy link
Member

@estelle estelle commented Feb 6, 2025 •
edited
Loading

CSS grid layout module sub-PR (#37999)

  • remove "I" language
  • see also links to current writing guideline standards
  • height of examples
  • general refresh
  • The slug of the alignment guide will be changed in a separate PR once all of the Module landing page: grid layout #37999 PRs are merged.

@estelle estelle requested a review from a team as a code owner February 6, 2025 22:45
@estelle estelle requested review from bsmth and removed request for a team February 6, 2025 22:45
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed labels Feb 6, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 6, 2025 •
edited
Loading

Preview URLs

External URLs (1)

URL: /en-US/docs/Web/CSS/CSS_grid_layout/Auto-placement_in_grid_layout
Title: Auto-placement in grid layout

(comment last updated: 2025-02-07 17:35:22)

This was referenced Feb 6, 2025
Merged
Closed
Merged
bsmth
bsmth approved these changes Feb 7, 2025
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comments to have a look at, otherwise looking good, tnx 👍🏻

@estelle estelle merged commit 607096d into main Feb 7, 2025
12 checks passed
@estelle estelle deleted the grid5 branch February 7, 2025 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsmth bsmth bsmth approved these changes

Assignees
No one assigned
Labels
Content:CSS Cascading Style Sheets docs size/m [PR only] 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estelle @bsmth