-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ci] Stop running CUDA tests at CI #4167
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I agree, this is the right thing to do for now. Otherwise the pull requests will keep piling up and it will get harder to manage them and for others to contribute.
@jameslamb I guess
should be fixed by #4158, right? |
it should, yep! I remember we've had issues like that before once about a week has passed after an R release. Was trying to get ahead of it with #4158. This puts us in a difficult position where now #4158 can't pass without this PR and this PR can't pass without #4158. Since neither of us have admin rights to merge while ignoring CI, and since this PR is just removing an entire file, it's ok with me if you push this CUDA change to the branch in #4158. |
Or, alternatively, comment out any R jobs that are breaking with this error and we can uncomment them in a later PR. Just to get things working again. |
I thought you have them. |
Oh! Interesting, I thought I'd lost them recently but it seems like I can merge with admin rights ONLY AFTER ALL CI CHECKS ARE DONE RUNNING (regardless of whether or not they succeed) I can't merge this one, for example. But I can merge #4158 (notice the button is not grayed out) And I can merge #4162 |
Ok this PR is almost done (just waiting on one more QEMU check to finish), I'll merge this with admin rights as soon as Azure completes. |
This reverts commit 36454a3.
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Unblock LightGBM development process.
Refer to #4165.
I hope in the near future we will just revert this commit and restore running CUDA at our CI.