Allow truncating SVG in AppNodeText #945
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additionally, use AppNodeText for SVG labels
✅ Deploy Preview for monarch-app ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #945 +/- ##
==========================================
+ Coverage 70.75% 70.97% +0.21%
==========================================
Files 91 91
Lines 3084 3128 +44
==========================================
+ Hits 2182 2220 +38
- Misses 902 908 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Labels in the phenogrid were previously rendered as
<text>SVG elements, rather than<AppNodeText>Vue elements which whitelist certain markup. This replaces thosetextelements withAppNodeTextelements.An issue, though, is that labels were previously truncated based on their bare text length. So the string
'label<b>with bolded</b>'might be truncated to'label<b'or'label<b>with bo'rather than'label with bo'(where "with bo" would be bolded).This PR fixes that bug by truncating text according to its length as it appears in rendered SVG.
Fixes the bug mentioned in #943 (comment).