Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/issue -744 - Page is scrolling while entering text input or sorting data #953

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

varun-divya
Copy link
Contributor

Summary

Checks

  • All tests have passed (or issues created for failing tests)

@varun-divya varun-divya changed the title Bugfix/issue -744 - Page is scrolling while entering text input and sorting data Bugfix/issue -744 - Page is scrolling while entering text input or sorting data Feb 14, 2025
Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for monarch-app ready!

Name Link
🔨 Latest commit 1c75ff0
🔍 Latest deploy log https://app.netlify.com/sites/monarch-app/deploys/67b7aa620e890f0008c45427
😎 Deploy Preview https://deploy-preview-953--monarch-app.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Feb 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.97%. Comparing base (b953722) to head (1c75ff0).
Report is 43 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #953      +/-   ##
==========================================
+ Coverage   70.75%   70.97%   +0.21%     
==========================================
  Files          91       91              
  Lines        3084     3128      +44     
==========================================
+ Hits         2182     2220      +38     
- Misses        902      908       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@varun-divya varun-divya self-assigned this Feb 14, 2025
@ptgolden ptgolden self-requested a review February 14, 2025 19:57
@kevinschaper
Copy link
Member

This one is extra challenging! If there's just one row in the table, it winds up kind of strange.

Screenshot 2025-02-17 at 4 30 00 PM

It's would be a bigger change, but it's probably worth exploring having the search bar above the table, rather than fighting with the table size.

@varun-divya varun-divya marked this pull request as draft February 18, 2025 16:45
@varun-divya varun-divya marked this pull request as ready for review February 20, 2025 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants