Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move update_publications make target outside of make data #957

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

ptgolden
Copy link
Member

This creates a separate make update_publications command which is separate from make data. The latter depends on an up-to-date Solr server to be running, while the former does not. It would be useful for people who don't continually run and update the Solr backend to be able to update the publications file.

Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for monarch-app canceled.

Name Link
🔨 Latest commit c574fd9
🔍 Latest deploy log https://app.netlify.com/sites/monarch-app/deploys/67b778e5c85f32000868b4ab

Copy link

codecov bot commented Feb 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.97%. Comparing base (b953722) to head (c574fd9).
Report is 44 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #957      +/-   ##
==========================================
+ Coverage   70.75%   70.97%   +0.21%     
==========================================
  Files          91       91              
  Lines        3084     3128      +44     
==========================================
+ Hits         2182     2220      +38     
- Misses        902      908       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ptgolden ptgolden merged commit 1454374 into main Feb 21, 2025
11 checks passed
@ptgolden ptgolden deleted the separate-update-publications-command branch February 21, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants