-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OMIM PMID, UMLS, and Orphanet mappings out of date #194
Draft
joeflack4
wants to merge
15
commits into
main
Choose a base branch
from
mappings-pmid-umls-orphanet
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t, but can use on ad hoc basis to review outputs in this format
- Add: New protections-disease-gene.tsv. The contents of it are now what we used to have in exclusions-disease-gene.tsv. We had accidentally misinterpreted these curated configurations as the opposite of what they were supposed to be. - Update: exclusions-disease-gene.tsv: Now empty - Update: Added code to handle protections.
- Renamed the protections file
- Renamed variables protections -> protected
- Update: removed some todos
- Update: Added entries to exclusions-disease-gene.tsv
- Update: Added exclusions to leave only 1 entry remaining in the file.
- Update: Moved entry OMIM:603956 back to exclusions from protections.
- Update: Add 2 more exclusions
…he case that they appear outside mim2gene.txt but not inside of it.
…tions Protected Disease-Gene
- Paths were incorrect
- Starting to pull from API rather than using local cache.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #192
Changes
Starting to pull from API rather than using outdated local cache.