containers: drop el8, fc36,fc37,fc38 and add fc40,fc41 #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bring the containers a bit up-to-date again. Drop CentOS 8 container and EOL Fedora releases and add Fedora 40 and Fedora 41. Signed-off-by: Jean-Louis Dupond <[email protected]>
Update our actions to newest versions in order to make it work again. Signed-off-by: Jean-Louis Dupond <[email protected]>
dupondje
force-pushed
the
update_containers
branch
from
6a60d6d to
e47717b
Compare
Install python3.12 packages on CentOS 9 in order to enable tests on that version. Signed-off-by: Jean-Louis Dupond <[email protected]>
dupondje
force-pushed
the
update_containers
branch
from
e47717b to
0a37e86
Compare
nirs
reviewed
Jan 24, 2025
| @@ -25,6 +26,9 @@ RUN echo v1 \ | |||
| python3.11-setuptools \ | |||
| python3.11-ovirt-engine-sdk4 \ | |||
| python3.11-pip \ | |||
| python3.12-devel \ | |||
| python3.12-setuptools \ | |||
| python3.12-pip \ | |||
There was a problem hiding this comment.
Why not replace python 3.11 with 3.12?
| @@ -14,6 +14,7 @@ RUN echo v1 \ | |||
| gcc \ | |||
| git \ | |||
| libguestfs-tools-c \ | |||
| libxml2-devel \ | |||
There was a problem hiding this comment.
Why is this needed? maybe add a comment?
| @@ -39,3 +43,4 @@ COPY requirements.txt requirements.txt | |||
| RUN python3 -m pip install --upgrade --ignore-installed pip \ | |||
| && python3 -m venv /venv \ | |||
| && /venv/bin/python3 -m pip install --requirement requirements.txt | |||
| RUN pip3.12 install ovirt-engine-sdk-python | |||
There was a problem hiding this comment.
Why use 2 version of pip inside the venv? If we must have python 3.12 to install ovirt-engine-sdk-python we should probably move to python 3.12.
If we don't have a better way at add a comment explaing why we do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring the containers a bit up-to-date again.
Drop CentOS 8 container and EOL Fedora releases and add Fedora 40 and Fedora 41.