Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

containers: drop el8, fc36,fc37,fc38 and add fc40,fc41 #213

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from
Draft

containers: drop el8, fc36,fc37,fc38 and add fc40,fc41 #213

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efe56d5
containers: drop el8, fc36,fc37,fc38 and add fc40,fc41
dupondje Jan 24, 2025
ab8b161
ci: use up-to-date actions
dupondje Jan 24, 2025
0a37e86
containers: add python3.12 to centos9 container
dupondje Jan 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions containers/centos-9.containerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ RUN echo v1 \
gcc \
git \
libguestfs-tools-c \
libxml2-devel \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this needed? maybe add a comment?

make \
openssl \
python3-devel \
Expand All @@ -25,6 +26,9 @@ RUN echo v1 \
python3.11-setuptools \
python3.11-ovirt-engine-sdk4 \
python3.11-pip \
python3.12-devel \
python3.12-setuptools \
python3.12-pip \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not replace python 3.11 with 3.12?

qemu-img \
qemu-kvm \
rpm-build \
Expand All @@ -39,3 +43,4 @@ COPY requirements.txt requirements.txt
RUN python3 -m pip install --upgrade --ignore-installed pip \
&& python3 -m venv /venv \
&& /venv/bin/python3 -m pip install --requirement requirements.txt
RUN pip3.12 install ovirt-engine-sdk-python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why use 2 version of pip inside the venv? If we must have python 3.12 to install ovirt-engine-sdk-python we should probably move to python 3.12.

If we don't have a better way at add a comment explaing why we do this.

Loading