[IMP] Inventory: Batch Picking 18 #11748
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jero-odoo
force-pushed
the
18.0-batch-picking-jero
branch
from
9a21c81 to
3d440d0
Compare
|
hey @benderliz this is ready for review. Thanks! |
benderliz
approved these changes
Jan 21, 2025
There was a problem hiding this comment.
Hi @jero-odoo Jess! Nice work on this PR, especially writing the new automated batching section. Left some comments to consider. Some of them are stylistic, and some I included UI screenshots from runbot 18.0, as I saw slightly different wording than what was written. Great job, I think this can move to final review after taking a look!
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/batch.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/batch.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/batch.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/batch.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/batch.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/batch.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/batch.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/batch.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/batch.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/batch.rst
Outdated
Show resolved
Hide resolved
jero-odoo
force-pushed
the
18.0-batch-picking-jero
branch
from
5c4bf3b to
a969b51
Compare
|
Thank you Liz! |
Felicious
approved these changes
Jan 22, 2025
There was a problem hiding this comment.
Hello @jero-odoo!
Great job on this PR! I had very minor suggestions, which you can implement as you see fit. I left a note about the barcode portion needing to be updated. I trust that you'll take a look at that and update it accordingly, so I'm approving this now. 😊
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/batch.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/batch.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/batch.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/batch.rst
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/batch.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/batch.rst
Outdated
Show resolved
Hide resolved
jero-odoo
force-pushed
the
18.0-batch-picking-jero
branch
from
4cfa990 to
52a437a
Compare
|
@samueljlieber this is ready for tech review. Thanks! |
jero-odoo
force-pushed
the
18.0-batch-picking-jero
branch
2 times, most recently
from
d8f8d98 to
4012003
Compare
samueljlieber
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Hi @jero-odoo! Nice work on this PR! Approving with a couple of comments for your consideration. Thank you for your work!
...
@robodoo delegate=jero-odoo
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/batch.rst
Outdated
Show resolved
Hide resolved
content/applications/inventory_and_mrp/inventory/shipping_receiving/picking_methods/batch.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Liz Bender <[email protected]> Co-authored-by: Felicia Kuan <[email protected]> Co-authored-by: Sam Lieber (sali) <[email protected]>
jero-odoo
force-pushed
the
18.0-batch-picking-jero
branch
from
0d15ca3 to
6bb58d4
Compare
|
@robodoo r+ |
This was referenced Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Batch Picking v18 based on SME feedback. Updated images and content.
Docs task:https://www.odoo.com/mail/view?model=project.task&res_id=4465730&access_token=8ddb0563-8bda-4742-9708-0269b39513d7