Forward-merge branch-24.08 to branch-24.10 #16813
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the changes that will be in the cudf-polars point release. --------- Co-authored-by: Thomas Li <[email protected]> Co-authored-by: David Wendt <[email protected]> Co-authored-by: brandon-b-miller <[email protected]> Co-authored-by: Vyas Ramasubramani <[email protected]> Co-authored-by: brandon-b-miller <[email protected]> Co-authored-by: Bradley Dice <[email protected]> Co-authored-by: Manas Singh <[email protected]> Co-authored-by: Manas Singh <[email protected]>
github-actions
bot
added
Python
| @@ -43,6 +47,9 @@ python -m pip install \ | |||
| "$(echo ./dist/libcudf_${RAPIDS_PY_CUDA_SUFFIX}*.whl)" \ | |||
| "$(echo ./dist/pylibcudf_${RAPIDS_PY_CUDA_SUFFIX}*.whl)" | |||
|
|
|||
| rapids-logger "Pin to 1.7.0 Temporarily" | |||
There was a problem hiding this comment.
this can be removed now
There was a problem hiding this comment.
I would do those changes in a follow-up PR where we unpin and also change the xfail/xpass status of that one test we discussed.
| python -m pip install $(echo ./dist/cudf_polars*.whl) | ||
|
|
||
| # TAG=$(python -c 'import polars; print(f"py-{polars.__version__}")') | ||
| TAG="py-1.7.0" |
There was a problem hiding this comment.
this should be removed now and the above line uncommented
|
Oh, more merge conflicts! I'll resolve again. |
|
@mroeschke Can you please let this PR go through before merging any more pylibcudf changes? Or should we run CI locally on this and admin-merge it to avoid further delay? |
… branch-24.10-merge-24.08
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual forward merge from 24.08 to 24.10. This PR should not be squashed.