Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConnectionClosed now reports peer node id #2281

Merged
merged 3 commits into from
Nov 13, 2024
Merged

ConnectionClosed now reports peer node id #2281

merged 3 commits into from
Nov 13, 2024
+107 −63

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Nov 13, 2024 •
edited
Loading

This was referenced Nov 13, 2024
Merged
Merged
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

Test Results

  7 files  + 2    7 suites  +2   4m 33s ⏱️ + 2m 42s
 47 tests + 2   46 ✅ + 2  1 💤 ±0  0 ❌ ±0 
182 runs  +69  179 ✅ +68  3 💤 +1  0 ❌ ±0 

Results for commit ecd19ac. ± Comparison against base commit c6c49d4.

♻️ This comment has been updated with latest results.

@AhmedSoliman AhmedSoliman mentioned this pull request Nov 13, 2024
Merged
@AhmedSoliman AhmedSoliman marked this pull request as ready for review November 13, 2024 13:28
tillrohrmann
tillrohrmann approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving our error reporting @AhmedSoliman. This will come very handy when debugging the next test instability :-) +1 for merging.

@AhmedSoliman AhmedSoliman merged commit ecd19ac into main Nov 13, 2024
23 checks passed
@AhmedSoliman AhmedSoliman deleted the pr2281 branch November 13, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

@muhamadazmy muhamadazmy Awaiting requested review from muhamadazmy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AhmedSoliman @tillrohrmann