Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix build #2282

Merged
merged 1 commit into from
Nov 13, 2024
Merged

fix build #2282

merged 1 commit into from
Nov 13, 2024
+11 −8

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Nov 13, 2024 •
edited
Loading

tillrohrmann
tillrohrmann approved these changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging.

@AhmedSoliman
Copy link
Contributor Author

Will merge after GHA

This was referenced Nov 13, 2024
Merged
Merged
@AhmedSoliman AhmedSoliman merged commit baab1d1 into main Nov 13, 2024
5 checks passed
@AhmedSoliman AhmedSoliman deleted the pr2282 branch November 13, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AhmedSoliman @tillrohrmann