Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comply with PEP 561 #2277

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Comply with PEP 561 #2277

wants to merge 2 commits into from

Conversation

ppfeister
Copy link
Member

Add type hints for exposed sherlock function, add py.typed to comply with PEP 561 and allow for detection by mypy for static type checking.

@ppfeister ppfeister added the enhancement New feature or request label Aug 28, 2024
@ppfeister ppfeister linked an issue Aug 28, 2024 that may be closed by this pull request
Stubs required for statically typed downstreams #2275
Open
1 task
@ppfeister
Copy link
Member Author

Odd. I figured Optional would be available without typing since other types like (lowercase) dict and (lowercase) list were brought into the std library, negating typing for many of those. Seems that it needs the import still.

Sometime tomorrow, I'll either add the import or switch it to the normal union without an import (str | None).

@ppfeister ppfeister mentioned this pull request Sep 12, 2024
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuardianWang GuardianWang GuardianWang left review comments

@sdushantha sdushantha Awaiting requested review from sdushantha

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stubs required for statically typed downstreams
2 participants
@ppfeister @GuardianWang