Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add $job property to QueueableAction to address deprecated dynamic properties in PHP >= 8.2 #111

Merged
merged 2 commits into from
Jan 19, 2025

Conversation

mostafaznv
Copy link
Contributor

@mostafaznv mostafaznv commented Jan 18, 2025

This pull request introduces updates to the GitHub Actions workflow and the QueueableAction trait to ensure compatibility with PHP versions 8.3 and higher, addressing the issue of deprecated dynamic properties.

  • Introduced a nullable $job property to the QueueableAction trait, preventing dynamic property warnings in PHP 8.2+.
  • Added PHP 8.3 and 8.4 to the testing matrix, ensuring the package’s compatibility with the latest PHP versions.

#110

@mostafaznv mostafaznv changed the title Fix: Add $job property to QueueableAction to address deprecated dynamic properties in PHP >= 8.3 Fix: Add $job property to QueueableAction to address deprecated dynamic properties in PHP >= 8.2 Jan 19, 2025
@freekmurze freekmurze merged commit 356cb39 into spatie:main Jan 19, 2025
12 checks passed
@freekmurze
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants