Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add $job property to QueueableAction to address deprecated dynamic properties in PHP >= 8.2 #111

Merged
merged 2 commits into from
Jan 19, 2025
Merged

Fix: Add $job property to QueueableAction to address deprecated dynamic properties in PHP >= 8.2 #111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbdc61d
chore: add php 8.3 and 8.4 to `run-tests.yml`
mostafaznv Jan 18, 2025
6d441ec
fix: add ``$job` property to `QueueableAction` to prevent `deprecated…
mostafaznv Jan 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/run-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
strategy:
fail-fast: true
matrix:
php: [8.2, 8.1, 8.0]
php: [8.4, 8.3, 8.2, 8.1, 8.0]
laravel: ['9.*', '10.*', '11.*']
dependency-version: [prefer-stable]
include:
Expand Down
3 changes: 3 additions & 0 deletions src/QueueableAction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,13 @@

namespace Spatie\QueueableAction;

use Illuminate\Contracts\Queue\Job;
use Spatie\QueueableAction\Exceptions\InvalidConfiguration;

trait QueueableAction
{
public ?Job $job;
freekmurze marked this conversation as resolved.
Show resolved Hide resolved

/**
* @return static
*/
Expand Down
Loading