Support MTEMP.TMP map header file + related CA_LoadFile changes #63
Conversation
The Catacomb 3-D sources and reconstructed Keen 4-6 v1.4-5 sources, along with Blake Stone sources, show no use of the function, while the known uses in the sources for the Catacomb Adventure Series and Wolfenstein 3D ignore the returned value.
By calling CAL_LoadFile_Int directly, it should be possible to open a file without adjusting its file extension.
MTEMP.TMP was the file generated by TED5.EXE for Carmack-compressed files, while MAPHEAD.EXT would be used for maps not going through that phase. The situation possibly changed in Wolfenstein 3D shareware v1.1, using MAPHEAD.EXT with Carmack compression altogether. Due to the lack of awareness for years, MAPHEAD.EXT had been commonly used for Keen 4-6 map editing with Carmack compression, and the open-source release of Keen Dreams from 2014 similarly used MAPHEAD.KDR with Huffman compression. For purposes of backwards compatibility, Omnispeak still accepts MAPHEAD.EXT.
|
I'm definitely happy to accept the first two fixes, but I don't like the MTEMP.TMP name, for a few reasons:
My feeling is that the ultimate correct solution here is to make all of the other filenames variables in EPISODE.CKx. This would allow individual mods/users to use MTEMP.TMP if they prefer, or to stick with MAPHEAD.CKx, or even MAPSHEAD.CKx (which seems to be, from an unused variable in the TED5 code, the originally intended name here). (Of course, I'd be happy to support MAPTEMP/MAPTHEAD at some point, too, for TED5 compatibility.) The LoadFile and AdjustExtension changes are fine, though. |
|
I think that I'll close this for now and let you decide if to cherry-pick anything. I'm not sure the CA_LoadFile split will be needed outside of my merge request, especially in case all filenames will eventually be define-able via EPISODE.CKx. My PR was meant to add MTEMP.TMP as an option while preserving support for MAPHEAD.CKx. As far as I know, MAPTHEAD.CKx was intended for internal use by TED5, while MAPHEAD.CKx would be used by the game in case maps were not using more than RLEW for compression (at least before Wolf3D shareware v1.1). Bio Menace (checked with the freeware version) uses MAPHEAD.BMx with MAPTEMP.BMx. There are files letting you use TED5 with Bio Menace. The files GAMEMAPS.BMx also exists, but they're practically unused. https://moddingwiki.shikadi.net/wiki/GameMaps_Format If MAPSHEAD.CKx hadn't had a known use so far, I'm not sure it's necessary to support the name separately. MTEMP.TMP was clearly generated by TED5 and could be used as-is, albeit it's not impossible the sole user of MTEMP.TMP for now, as far as it comes to released modifications, was me. The released files for "Keen Dreams - Unofficial Tech Demo" (2015, within an internal subdir) and "NY00123's tests level" (2017) should include MTEMP.TMP files. But I think that even the tests level will not work under Omnispeak without making a source mod. So far, I've usually had each game/mod in a separate directory, so you've brought a good point about the file extensions letting you have all episodes' data in the same directory for Omnispeak. |
No description provided.