id_ca: Use filenames from EPISODE.CKx #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That looks good in idea. The removal of AdjustExtensions() calls is an advantage that I can see, indeed. As probably expected, Omnispeak as present in this revision will refuse to start without the added EPISODE.CKx definitions, but with them, it seems to load the data. Question is in what manners may this have a part in case you decide to go for another way of loading mods, like selecting a directory or loading from a PK3 file. A few notes about code changes that I've seen:
|
sulix
force-pushed
the
cafiles
branch
2 times, most recently
from
390fe80
to
2a1f60b
Compare
Instead of hardcoding the filenames for the various files needed by ID_CA (i.e., audio, graphics, and level files), load them from variables in EPISODE.CKx. This gets rid of some AdjustExtension() calls, as well as making it easier for mods to use the different filenames produced by different tools (e.g. EDITMAPS, MAPTEMP, etc). Note that this doesn't do anything fancy with the episode detection or anything yet, nor does it cover other files, outside ID_CA.
The Quit() function is used to terminate the game on a fatal error, and
accepts a single string as its message (the normal end screen is
displayed if the message is NULL). However, we often would like to
provide extra diagnostic information in these circumstances, such as the
filename we couldn't load, or similar. This is particularly important as
more data moves to being loaded or defined at runtime, so can't be baked
into static strings.
The new QuitF() function behaves exactly like Quit(), but the message is
now a printf-style format string, and additional arguments can be
passed in afterwards.
For example:
QuitF("Couldn't load file %s!", filename)
This is a useful debug line, IMO.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@NY00123 Would something like this work as a replacement for #63? (Obviously there are a few tidy-ups, support for a few other files which would be required, but if the concept's sound, we can just change
ca_mapFileet al.)Instead of hardcoding the filenames for the various files needed by ID_CA (i.e., audio, graphics, and level files), load them from variables in EPISODE.CKx.
This gets rid of some AdjustExtension() calls, as well as making it easier for mods to use the different filenames produced by different tools (e.g. EDITMAPS, MAPTEMP, etc).
Note that this doesn't do anything fancy with the episode detection or anything yet, nor does it cover other files, outside ID_CA.