[RSDK-9933] update github action for new release format #29
Conversation
.github/workflows/publish.yaml
Outdated
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: viamrobotics/build-action@v1 | ||
| with: | ||
| # note: you can replace this line with 'version: ""' if you want to test the build process without deploying | ||
| version: ${{ github.ref_name }} |
There was a problem hiding this comment.
This has to change to github.event.release.tag_name
There was a problem hiding this comment.
Done. Good catch!
|
Ruh-roh. |
.github/workflows/publish.yaml
Outdated
| - uses: actions/checkout@v3 | ||
| - uses: viamrobotics/build-action@v1 |
There was a problem hiding this comment.
I believe v1 is the latest from viam. I've updated the checkout action to v4, which appears to be a drop-in replacement.
|
No, the dependency problems are not going to be transient: various things have changed in the past 7 months, and this needs to update to match. Taking a deeper look... |
There was a problem hiding this comment.
Looks like in the past 7 months, github has upgraded to python 3.13, which is not supported in pillow 10 or numpy 1.25. I've bumped both requirements to versions that support python 3.13, though that probably means I should try out the whole module locally...
.github/workflows/publish.yaml
Outdated
| - uses: actions/checkout@v3 | ||
| - uses: viamrobotics/build-action@v1 |
There was a problem hiding this comment.
I believe v1 is the latest from viam. I've updated the checkout action to v4, which appears to be a drop-in replacement.
penguinland
force-pushed
the
update_publish_action
branch
from
42aa3a7 to
51d6d5c
Compare
|
This PR won't pass its checks until #30 is merged. |
penguinland
force-pushed
the
update_publish_action
branch
from
51d6d5c to
f0a5316
Compare
|
Hooray, the checks pass this time! |
Tagging Bijan because Khari is super busy.
I haven't tried this out, but it's mostly copied from https://github.com/viam-modules/viam-mlmodelservice-triton/blob/main/.github/workflows/publish.yml, which I have tried.