-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RSDK-9936] Get the CI system to build the module again #30
Conversation
… installing requirements in github actions
@@ -34,5 +34,7 @@ echo installing dependencies from requirements.txt | |||
$VIRTUAL_ENV/bin/pip install -r requirements.txt -U | |||
source $VIRTUAL_ENV/bin/activate | |||
$PYTHON -m PyInstaller --onefile --hidden-import="googleapiclient" --add-data="./src:src" src/main.py | |||
# When running as a local module, we need meta.json to be in the same directory as the module. | |||
ln -sf ../meta.json dist |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line looks wrong, but it's right. It looks like "look one directory up for a file, and add a symlink in dist/" but it's actually "add to dist/ a symlink that goes one directory up from there (to the current directory).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having to include the meta.json in the dist for pyInstaller builds I think is something we've encountered before too, and seems like potentially something we didn't expect? I would want to ask people working on our module building if this is expected behavior (does meta.json need to be the PyInstaller dist) @michaellee1019
In addition to your manual test that you did, I'd like you to release an -rc version to the registry and see if it also works on your orin nano
My understanding (which I haven't double-checked recently) is that meta.json needs to be in the directory where you run
I could do this manually, but I'd prefer to merge this and #29 and then do it via github. Would that be alright? |
We discussed in person: the release candidate can wait until after #29 is merged. |
Yes, version 0.2.9-rc1 works on my Orin Nano! I'm going to release 0.2.9 as a non-RC. |
Tried on my Orin Nano: seems to work!
Changes include:
pillow
andnumpy
to py3.13-compatible versions.pytest-asyncio
, so I added that in.git status
shows the repo as clean even after running the tests. Why didn't other people have this issue in the past? I wonder if I was supposed to set things up differently...make setup
. I could be wrong about this: maybe you want the presence of those build artifacts front-and-center.make setup
a second time. That has a bit of a smell, but I couldn't think of a better approach. Any ideas?SUBTYPE
toAPI
recently, so I renamed to match.There's still something slightly off:
make dist/archive.tar.gz
failed with errors about a nonexistent file, until I ranmake setup
. Since then,make dist/archive.tar.gz
doesn't run because everything is up-to-date even though I edited the code. but perhaps that's a problem for another day.(I also had spurious errors about being unable to open /tmp/something/libpython3.10.so, but then they spontaneously disappeared 🤷 )