dejavu now supports Python 3

[David-Dietrich-wins]

Good afternoon worldveil,
First, terrific package. Really easy to follow a fairly complex topic. I just finished upgrading the dejavu audio fingerprinting code to Python 3. Took a while to get that one with all of the Python changes.

Can you create a new branch for the Python 3 version? I sound like a noob as this is the first Python project and Pull Request I've done.

Thank you for the great work and have a terrific weekend,
David Dietrich
GrayArrow

[tkhurana96]

@GrayArrow first of all great work, While using dejavu for python3, I got this error:

File "/src/dejavu/fingerprint.py", line 110, in get_2D_peaks detected_peaks = np.subtract(local_max, eroded_background) TypeError: numpy boolean subtract, the -operator, is deprecated, use the bitwise_xor, the^ operator, or the logical_xor function instead.

Thought to let you know.

[fpSpindola]

@tkhurana96 hmm, just opened a merge request here about this issue
Actually it's not a problem of Python3 itself, it's a numpy version issue
If you replace your Numpy (probably 1.14.5) to 1.13.1 it will work perfectly

[gabeboileau]

Will this branch be merged in anytime soon? Or is this project no longer active?

[lordkyzr]

This project has not been active in a while. I've used this for years now and it's not had any updates. Just fork it and merge the branch.

…

On Sat, Dec 22, 2018, 11:52 AM Gabe ***@***.*** wrote: Will this branch be merged in anytime soon? Or is this project no longer active? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#117 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AEOa7u-VmFOo48NNBb8wwhx6F5M_TOB2ks5u7o1ngaJpZM4NvLRG> .

[gabeboileau]

@lordkyzr Thank you, that was my initial thought as well. I'll fork and merge.

[sunravi]

Hi guys,

I have very limited knowledge about Git. I tried to use Datawookie's fork, (in windows). But I got an error. I have a doubt, that it is not designed for windows?
Is it easy to create a windows version of this. No doubt it is a great project.

[Coltin-dev]

Hey has anyone had issues installing pyaudio for python3.6?

[David-Dietrich-wins]

Looks good. Thank you for the update.

[subins2000]

Any ETA on when this is merged ?

[kevinschaich]

Hey guys – don't think it's super clear from the commit log as a lot of vaguely named PRs got merged all at once, but the master branch of this repo worked out of the box on Python 3.10.9 for me on Mac. Don't pip install dejavu as the ones on Pypi etc. are outdated.