Support setting typing status #897
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UserSettingName has been moved to another file. Signed-off-by: Zixuan James Li <[email protected]>
This is not prohibited by the server and we should not log expected behaviors like this. See: https://zulip.com/api/get-events#typing-start Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
An issue that exists prior to this change is that there can be unused prepared responses when the test ends, but we don't have a way to detect that. We can potentially do something like what testWidgets does with pending timers. Signed-off-by: Zixuan James Li <[email protected]>
PIG208
force-pushed
the
set-typing-2
branch
2 times, most recently
from
9401ef0
to
8cf2d81
Compare
Signed-off-by: Zixuan James Li <[email protected]>
The stopwatch gets replaced with a testable stopwatch from clock/clock in tests. We need to for testability of stopwatches with fake async. The "normal" stopwatch gets used when not testing. This implementation was inspired by: https://github.com/flutter/flutter/pull/137381/commits/ bbdeabf74b8e9443f0156b4631d460f022ac598c Signed-off-by: Zixuan James Li <[email protected]>
The debugEnable setup is borrowed from debugEnableRegisterNotificationToken. This acts as a hook to temporarily disable typing notifications in later widget tests. The documentation and implementation are based on the web app: https://github.com/zulip/zulip/blob/52a9846cdf4abfbe937a94559690d508e95f4065/web/shared/src/typing_status.ts Signed-off-by: Zixuan James Li <[email protected]>
Signed-off-by: Zixuan James Li <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to and stacked on top of #888