This repository has been archived by the owner on Feb 4, 2025. It is now read-only.
Add Stock photo caption and include it when uploading a photo #1846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Caption field has been added to be included in the payload when uploading a stock media item.
The caption value is parsed when deserializing the response of searching.
3 tasks
...n/java/org/wordpress/android/fluxc/network/rest/wpcom/stockmedia/SearchStockMediaResponse.kt
Outdated
Show resolved
Hide resolved
jd-alexander
suggested changes
Jan 21, 2021
There was a problem hiding this comment.
Looks good @fluiddot I checked the code including the tests and all is well. I left a comment you can check out as well. Once that's resolved we can LGTM this.
Co-authored-by: Joel Dean <[email protected]>
jd-alexander
approved these changes
Jan 21, 2021
There was a problem hiding this comment.
Thanks for these changes @fluiddot We are good to go! LGTM 🚢
This was referenced Jan 26, 2021
Closed
|
@fluiddot there's a conflict here that will require resolution :) |
# Conflicts: # fluxc/src/main/java/org/wordpress/android/fluxc/persistence/WellSqlConfig.kt
Thanks @jd-alexander for raising the issue, I've just solved the conflict in f2e5d10. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: wordpress-mobile/gutenberg-mobile#1609
Related PRs
gutenberg-mobilegutenbergWordPress-iOSWordPress-AndroidDescription
Parse
captionfield from the response of Stock media search requests and add it to the Stock media model and item. This field is now also included in the payload when a photo is uploaded.Test
The changes can be tested in two different flows:
Media screen
Steps
Mediabutton.+button.Choose from Free Photo LibraryCaptionfield has value.Note: It's possible that in some cases the item doesn't have a caption value with the credit/attribution of the photo. In this case try another one.
Image block
Steps
+button.Imageblock.ADD IMAGE.Choose from Free Photo LibraryNote: It's possible that in some cases the item doesn't have a caption value with the credit/attribution of the photo. In this case try another one.
Merge Instructions:
Only merger after WordPress Android PR has been tested and approved.