Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add media caption when adding an image or video #3046

Draft
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

fluiddot
Copy link
Contributor

@fluiddot fluiddot commented Jan 25, 2021

Fixes #1609

Related PRs

Description

This PR addresses the following topics:

Upload credit/attribution of photos from free photo library

The idea is to upload as the caption of the media item the credit/attribution from photos that we get from the free photo library (Pexels). The changes for this have been applied in the native projects (iOS and Android).

Include caption of media items when inserting them into a block

This covers the Image and Video block.

How has this been tested?

Image

The following steps are for iOS version but they're very similar on Android.

  1. Go to a site.
  2. Open a post/page.
  3. Tap on + button.
  4. Tap on Image block.
  5. Tap on ADD IMAGE.
  6. Tap on Free Photo Library
  7. Search any term.
  8. Tap one photo.
  9. Wait for the item to be uploaded.
  10. Check that below the photo the caption field has a value.
Video

The following steps are for iOS version but they're very similar on Android.

For this flow a site with a premium plan is required.

  1. Go to a site.
  2. Go to media screen.
  3. Tap on + button.
  4. Tap on Choose from My device button.
  5. Tap on video item.
  6. Wait for the item to be uploaded.
  7. Tap on the uploaded item.
  8. Edit the caption and put some text.
  9. Open a post/page.
  10. Tap on + button.
  11. Tap on Video block.
  12. Tap on ADD VIDEO.
  13. Tap on WordPress Media Library
  14. Tap on uploaded item.
  15. Check that below the video the caption field has the value previously set.

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered if this change warrants user-facing release notes more info and have added them to RELEASE-NOTES.txt if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] In Progress [Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add photo credit as caption when adding an image from Free Photo Library
1 participant