Add Stock photo caption and include it when uploading a photo

[fluiddot]

Issue: wordpress-mobile/gutenberg-mobile#1609

Related PRs

• gutenberg-mobile
• gutenberg
• WordPress-Android
• WordPress-FluxC-Android

Description

Add the caption field to the Stock photo upload request.

Test

The changes can be tested in two different flows:

Image block

Steps

1. Go to a site.
2. Open a post/page.
3. Tap on + button.
4. Tap on Image block.
5. Tap on ADD IMAGE.
6. Tap on Free Photo Library
7. Search any term.
8. Tap one photo.
9. Wait for the item to be uploaded.
10. Check that below the photo the caption field has a value.

Note: It's possible that in some cases the item doesn't have a caption value with the credit/attribution of the photo. In this case try another one.

Media screen (currently not working 🔴 due this issue)

Steps

1. Go to a site.
2. Tap on Media button.
3. Tap on + button.
4. Tap on Choose from Free Photo Library
5. Search any term.
6. Tap one or multiple photos.
7. Tap on ✔️ button.
8. Wait for the items to be uploaded.
9. [Back in the Media screen] Tap on any of the recently uploaded photos.
10. Check that Caption field has value.

Note: It's possible that in some cases the item doesn't have a caption value with the credit/attribution of the photo. In this case try another one.

Screenshots

Image block

image-block-caption-ios.mov

Media screen (currently not working 🔴 due this issue)

media-screen-caption-ios.mp4

PR submission checklist:

• I have considered adding unit tests where possible.
• I have considered adding accessibility improvements for my changes.
• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[peril-wordpress-mobile]

You can test the changes on this Pull Request by downloading it from AppCenter here with build number: 41023. IPA is available here. If you need access to this, you can ask a maintainer to add you.

[peril-wordpress-mobile]

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

[fluiddot]

I found out that the caption value is included in the upload request, however the site is not creating the media item with it so most likely the way we include the parameter for the caption is deprecated. I created an issue in WordPressKit-iOS repository describing the problem.

[peril-wordpress-mobile]

	Fails
🚫	Podfile: reference to a commit hash

	Warnings
⚠️	This PR is tagged with 'DO NOT MERGE'.

Generated by 🚫 dangerJS

[twstokes]

👋 I'm going to close this PR due to lack of activity, but please reopen if this was an error. Thank you.